On Mon, Feb 25, 2008 at 11:08 AM, Ravikiran Thirumalai <[EMAIL PROTECTED]> wrote: > On Sun, Feb 24, 2008 at 01:29:03PM +0100, Andi Kleen wrote: > >On Sat, Feb 23, 2008 at 09:48:42PM -0800, Yinghai Lu wrote: > >> > >> quad core 8 socket system will have apic id lifting.the apic id range > could > >> be [4, 0x23]. and apic_is_clustered_box will think that need to three > clusters > >> and that is large than 2. So it is treated as clustered_box. > > > >Ok I see you chose the quick hack over doing it properly ... > > > >> > >> and will get > >> > >> Marking TSC unstable due to TSCs unsynchronized > >> > >> even the CPUs have X86_FEATURE_CONSTANT_TSC set. > > > >I doubt that will do the right thing on AMD based vSMP, > >which also required the cluster check on AMD iirc. > > > > Andi, Yes. AMD based vSMPowered systems uses clustered APICs, and this > check base on cpu vendor id is not good :(.
please check if you happy with http://lkml.org/lkml/2008/2/24/273 Thanks Yinghai Lu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
