On Sun, Feb 24, 2008 at 10:23:49AM +0000, Mark Brown wrote:
> On Sat, Feb 23, 2008 at 09:52:17AM +0000, Russell King - ARM Linux wrote:
> > On Sat, Feb 23, 2008 at 12:05:38AM -0800, Andrew Morton wrote:
>
> > > > +#undef current
>
> > > err, no ;) Please rename your stuff.
>
> > Renaming is not an option - "current" is an electronic term for which
> > there is no alternative. The real problem is this __ATTR macro crap:
>
> Indeed, and this is already being worked around by
> drivers/power/power_supply_sysfs.c:
>
> #define POWER_SUPPLY_ATTR(_name) \
> { \
> .attr = { .name = #_name, .mode = 0444, .owner = THIS_MODULE }, \
My argument is - why bother with stuff like this, why not just pass
"_name" as the string itself, rather than using the preprocessor to
turn symbols into strings thereby suffering these nasty interactions.
It's not like "_name" is used for anything other than generating a
string.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
