Jens Axboe wrote: > On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: >> On Sun, 17 Feb 2008 20:29:13 +0100 >> Jens Axboe <[EMAIL PROTECTED]> wrote: >> >>> It's odd stuff. Could you perhaps try and add some printks to >>> block/cfq-iosched.c:call_for_each_cic(), like dumping the 'nr' return >>> from radix_tree_gang_lookup() and the pointer value of cics[i] in the >>> for() loop after the lookup? >>> >> I met the same issue on ia64/NUMA box. >> seems cisc[]->key is NULL and index for radix_tree_gang_lookup() was >> always '1'. > > Why does it keep repeating then? If ->key is NULL, the next lookup index > should be 1UL. > > But I think the radix 'scan over entire tree' is a bit fragile. This > patch adds a parallel hlist for ease of properly browsing the members, > does that work for you? It compiles, but I haven't booted it here yet... > >> Attached patch works well for me, but I don't know much about cfq. >> please confirm. > > It doesn't make a lot of sense, I'm afraid. > > block/blk-ioc.c | 35 +++++++++++++++-------------------- > block/cfq-iosched.c | 37 +++++++++++-------------------------- > include/linux/iocontext.h | 2 ++ > 3 files changed, 28 insertions(+), 46 deletions(-) > > diff --git a/block/blk-ioc.c b/block/blk-ioc.c > index 80245dc..73c7002 100644 > --- a/block/blk-ioc.c
<snip> Hi Jens, Thanks for the patch. The patch works fine, machine boots up without the kernel panic. -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
