On Mon, Feb 18, 2008 at 02:45:56AM +0300, Oleg Nesterov wrote: > On 02/17, Jarek Poplawski wrote: ... > > 1) ... workqueue_cpu_callback(...) ... > Yes, but this is harmless. cpu-hotplug callbacks are not time-critical, > and cpu_down/cpu_up happens not often, and LIST_HEAD(workqueues) is not > very long, so ... > > > 2) ... __create_workqueue_key(...) ... > > Shouldn't this list_add() be done after all these inits below? > This doesn't matter. Please note that get_online_cpus() blocks > cpu_up/cpu_down, they take cpu_hotplug_begin().
You are completely right. It looks like this was only about ..."look". (But adding only "default:" in 1) would make it look nicer to me...) Regards, Jarek P. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
