Hi Konrad, On Wed Sep 2, 2026 at 10:51 AM CEST, Konrad Dybcio wrote: > On 9/1/26 10:58 AM, Luca Weiss wrote: >> Add the missing smps3-6 and ldo17 definitions. While smps3/5 and ldo17 >> are not used from the rpmh regulator driver on SM6350, the regulators do >> exist, so add them with the types based on the datasheet. >> >> Signed-off-by: Luca Weiss <[email protected]> >> --- >> drivers/regulator/qcom-rpmh-regulator.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/regulator/qcom-rpmh-regulator.c >> b/drivers/regulator/qcom-rpmh-regulator.c >> index dd2265961151..7d20f3e47760 100644 >> --- a/drivers/regulator/qcom-rpmh-regulator.c >> +++ b/drivers/regulator/qcom-rpmh-regulator.c >> @@ -1591,7 +1591,10 @@ static const struct rpmh_vreg_init_data >> pm6150l_vreg_data[] = { >> static const struct rpmh_vreg_init_data pm6350_vreg_data[] = { >> RPMH_VREG("smps1", SMPS, 1, &pmic5_ftsmps510, "vdd-s1"), >> RPMH_VREG("smps2", SMPS, 2, &pmic5_hfsmps510, "vdd-s2"), >> - /* smps3 - smps5 not configured */ >> + RPMH_VREG("smps3", SMPS, 3, &pmic5_ftsmps510, "vdd-s3"), >> + RPMH_VREG("smps4", SMPS, 4, &pmic5_ftsmps510, "vdd-s4"), >> + RPMH_VREG("smps5", SMPS, 5, &pmic5_ftsmps510, "vdd-s5"), >> + RPMH_VREG("smps6", SMPS, 6, &pmic5_hfsmps510, "vdd-s6"), >> RPMH_VREG("ldo1", LDO, 1, &pmic5_nldo, "vdd-l1"), >> RPMH_VREG("ldo2", LDO, 2, &pmic5_pldo, "vdd-l2-l5-l7"), >> RPMH_VREG("ldo3", LDO, 3, &pmic5_pldo, "vdd-l3-l6-l8-l9-l10"), >> @@ -1608,7 +1611,7 @@ static const struct rpmh_vreg_init_data >> pm6350_vreg_data[] = { >> RPMH_VREG("ldo14", LDO, 14, &pmic5_pldo, "vdd-l12-l14"), >> RPMH_VREG("ldo15", LDO, 15, &pmic5_nldo, "vdd-l15-l19-l22"), >> RPMH_VREG("ldo16", LDO, 16, &pmic5_nldo, "vdd-l16"), >> - /* ldo17 not configured */ >> + RPMH_VREG("ldo17", LDO, 17, &pmic5_nldo, "vdd-l17"), > > L17 (and other NLDOs on this PMIC) can do 0.312 - 1.304 V, whereas > the pmic5_nldo config allows a range of 0.32 - 1.296 V. But I suppose > that is something to fix separately anyway
Can you help with what numbers from the data sheet we're supposed to use? In 80-PR887-1 Rev. G, Table 3-20 would suggest L17 is programmable from 0.312V to 1.328V while "output voltage range" is 0.32V-1.304V. But Table 3-11 does indeed show 0.312V - 1.304V as "Programming range" for this specific LDO. So the voltages from the Table 3-11 are the ones to use? The other ones can be ignored completely? But e.g. the step size is only listed in 3-20. Sidenote, are the step sizes for the SMPS listed anywhere? Regards Luca > > Reviewed-by: Konrad Dybcio <[email protected]> > > Konrad
