Requesting feedback on this approach of adding additional chip support to leds-aw2013.
It comes with some downsides, such as the rename introducing Kconfig option and module-name incompatibilities. Additionally, there may be easy confusion between the pre-existing aw200xx and the proposed aw20xx, differing only by plus-or-minus a zero. However, given this approach in aw200xx, I think aw20xx can follow suit in a similar fashion. The 20xx series chips are all similar 3-channel LED drivers, see the driver commit for a comparison link. Lastly, I noticed this driver does not have an entry in the MAINTAINERS file. Let me know if that needs updating and how please. My working tree is also available on GitHub if you prefer that interface for any reason: https://github.com/sajattack/sdm660-linux/commits/b4/aw2013-aw20xx-rename/ This RFC resulted out of discussions pertaining to sdm660-mainline/linux, a close-to-mainline fork for Qualcomm Snapdragon 660 devices, specifically for the BlackBerry KEY2 Keyboard Backlight, in the following GitHub PR: https://github.com/sdm660-mainline/linux/pull/218 Signed-off-by: Paul Sajna <[email protected]> --- Paul Sajna (3): dt-bindings: leds: aw2013: Add aw2027 compatible and rename to aw20xx leds: aw2013: Rename to aw20xx leds: aw2013: Add AW2027 support and rename to aw20xx .../leds/{leds-aw2013.yaml => leds-aw20xx.yaml} | 10 +- drivers/leds/Kconfig | 14 +- drivers/leds/Makefile | 2 +- drivers/leds/leds-aw2013.c | 441 ----------------- drivers/leds/leds-aw20xx.c | 525 +++++++++++++++++++++ 5 files changed, 541 insertions(+), 451 deletions(-) --- base-commit: 944a035ecca915ae947905dcfb03f2b9dc6d032c change-id: 20260907-aw2013-aw20xx-rename-df233c5921c6 Best regards, -- Paul Sajna <[email protected]>
