> -----Original Message-----
> From: Sahil Chandna <[email protected]>
> Sent: Tuesday, September 1, 2026 8:18 AM
> To: KY Srinivasan <[email protected]>; Haiyang Zhang
> <[email protected]>; [email protected]; Dexuan Cui
> <[email protected]>; Long Li <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH] net: mana: Reserve extra CQ slot for the fence completion
> CQE
>
> The RX completion queue is sized to hold exactly one CQE per posted RX
> WQE.
> MANA_FENCE_RQ makes hardware post an additional CQE_RX_OBJECT_FENCE after
> the packet CQEs. The current sizing reserves no extra slot for it and in
> rare cases, CQ has no guaranteed slot for the fence CQE when it is full of
> packet CQEs. This can lead to dropping the fence completion while the
> driver waits holding RTNL lock throughout the timeout duration.
> Reserve one extra CQE slot for CQE_RX_OBJECT_FENCE. mana_gd_alloc_memory()
> requires queue_size to be a power-of-two and at least MANA_PAGE_SIZE;
> the reservation pushes cq_size past a power-of-two, so round up the CQ
> size
> in mana_create_rxq().
>
> Fixes: 6cc74443a773 ("net: mana: Add RX fencing")
> Signed-off-by: Sahil Chandna <[email protected]>
The code change looks good.
Reviewed-by: Haiyang Zhang <[email protected]>
For bug fixes, please indicate "net" branch in the Subject, and add
Cc: [email protected]
Thanks,
- Haiyang
