On 27/08/2026 19:31, Jakub Kicinski wrote: > On Tue, 25 Aug 2026 12:07:58 +0300 Nimrod Oren wrote: >> Would it be preferable for cmd() to terminate and wait for >> timed-out subprocesses? > > Meaning send a kill signal and then wait? Does it help anything?
It can help isolate tests so unwanted behavior does not carry over, like the timed-out ethtool command continuing to hold the RTNL lock. Rebooting would address this too. > Regarding the patch - I'm not sure we should be complicating > tests for this. How about we make NIPA reboot the machine if > it sees subprocess.TimeoutExpired ? Adding defer()s before > seems like a bit of a whack-a-mole. Sounds good to me. Rebooting will be cleaner.
