Christoph wrote: > Good. And remove the enum. > > It would be better to add some sort of flags field?
On the other hand, despite my brilliant (hah!) endorsement of bit field flags in my reply a few minutes ago, I'd settle for (1) removing the enum, and (2) using a flags field and more defines for the new stuff. I will grant that Christoph is correct that that form is more common in the kernel, and there is something to be said for doing things in the most common manner. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL PROTECTED]> 1.940.382.4214 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/