On Tue, Jul 21, 2026 at 06:18:05PM +0300, Ido Schimmel wrote:
> Alignment is off

Fixed for v3.  The "int hash" and "__be16 *fdb_port" continuation
lines now align under the first argument (the column just after the
opening paren) in nexthop_path_fdb_result().

> Remove the check given 'fdb_port' is never NULL?

Done for v3.  Dropped the "if (fdb_port)" guard; the only caller,
vxlan_fdb_nh_path_select(), always passes the address of an on-stack
__be16, so the store is unconditional now:

        nhi = rcu_dereference(nhp->nh_info);
        *fdb_port = nhi->fdb_port;
        return &nhi->fib_nhc;

Thanks,
Jack

Reply via email to