This series makes two small improvements to the SMEM GLINK transport: 1. Validate the raw FIFO head/tail indices (and caller-supplied offset/count) against the FIFO length in the read/write helpers, so a broken index is rejected before it turns into an out-of-bounds access into the FIFO.
2. Pass dev_name(&smem->dev) as the IRQ name instead of the static string "glink-smem". On platforms with multiple remoteprocs each SMEM GLINK instance registers its own IRQ, and the unique device name makes each entry in /proc/interrupts identifiable without adding a new struct field. Signed-off-by: Chunkai Deng <[email protected]> --- Changes in v3: - Rework the FIFO-index patch per review: validate the raw head/tail values (not a derived length or post-normalized index), use dev_warn_ratelimited() for remote-written indices and WARN_ON_ONCE() for local ones, and bounds-check offset/count and hlen/dlen. Retitled to "rpmsg: glink: smem: Validate FIFO indices before use". - No changes to the IRQ-name patch; carrying Dmitry's Reviewed-by. - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - Drop the modulo patch ("rpmsg: glink: smem: Use modulo for FIFO tail wrap-around in rx_advance"); per review, it papers over an unreachable scenario without restoring a valid protocol state. Proper RX-side validation of chunk_size against rx_pipe->length will be sent as a separate patch. - "rpmsg: glink: smem: Add WARN_ON_ONCE for FIFO index invariants": - Drop the trailing comma after "skipped" in the commit message body (per review). - Add Fixes: caf989c350e8 ("rpmsg: glink: Introduce glink smem based transport") and Cc: [email protected] (per review). - Carry Dmitry's Reviewed-by on "rpmsg: glink: smem: Use device name as IRQ name" (no code changes since v1). - Link to v1: https://patch.msgid.link/[email protected] --- Chunkai Deng (2): rpmsg: glink: smem: Use device name as IRQ name rpmsg: glink: smem: Validate FIFO indices before use drivers/rpmsg/qcom_glink_smem.c | 41 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) --- base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad change-id: 20260601-rpmsg-improvements-643a6e133f66 Best regards, -- Chunkai Deng <[email protected]>
