On 6/25/26 12:48, Jakub Sitnicki wrote: > On Wed, Jun 24, 2026 at 02:39 PM -07, Kuniyuki Iwashima wrote: >> On Wed, Jun 24, 2026 at 2:33 PM Kuniyuki Iwashima <[email protected]> wrote: >>> ... >>> Setting SOCK_RCU_FREE itself should not cause a problem, but I think >>> we should take a step back. >>> >>> AFAIU, 0c48eefae712 was to allow putting AF_UNIX SOCK_DGRAM sockets >>> into sockmap, not to allow using unconnected UDP sockets in sk_lookup etc. >>> >>> Actually, v4 of the patch was implemented as such but did not get any >>> feedback, >>> https://lore.kernel.org/bpf/[email protected]/#t >>> >>> ... and v5 (the final commit) somehow removed the restriction for >>> unconnected >>> UDP socket as well. >>> https://lore.kernel.org/bpf/[email protected]/ >>> >>> Given the initial use case, sockmap redirect, is still blocked by >>> TCP_ESTABLISHED >>> check in sock_map_redirect_allowed(), I feel there is no point in supporting >>> unconnected UDP sockets in sockmap. It cannot get any skb from anywhere >>> (without buggy sk_lookup). >> >> s/unconnected/unhashed/g :) > > Rejecting unhashed UDP sockets on insert to sockmap SGTM. > It is also in line with disable-problematic-cases strategy.
OK, here's v2 with the sock_map_sk_state_allowed() check reintroduced: https://lore.kernel.org/bpf/[email protected]/ Thanks, Michal
