On 6/3/26 5:48 PM, Erikas Bitovtas wrote:
> Add device tree for Sony Xperia M2 (sony-eagle) smartphone
> based on the Qualcomm MSM8926 SoC.
>
> Initial features:
> - Framebuffer
> - GPIO buttons (Volume Down and Camera)
> - Regulators
> - Internal storage
> - SD card
> - Accelerometer
> - Magnetometer
> - Ambient Light/Proximity sensor
> - NFC
> - pm8226_resin (Volume Up)
> - USB/Charger
>
> Signed-off-by: Erikas Bitovtas <[email protected]>
> ---
[...]
> + gpio-keys {
You should define a pinctrl state for each button, to presumably
configure pull-ups as necessary
[...]
> + accelerometer@f {
> + compatible = "kionix,kxtj21009";
> + reg = <0x0f>;
> +
> + interrupts-extended = <&tlmm 49 IRQ_TYPE_EDGE_RISING>;
> +
> + vdd-supply = <&pm8226_l19>;
> + vddio-supply = <&pm8226_lvs1>;
> +
> + mount-matrix = "0", "1", "0",
> + "-1", "0", "0",
> + "0", "0", "1";
nit: please align the "s
other than that:
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
