On 06-07 14:58, Mike Rapoport wrote:
> On Fri, 05 Jun 2026 03:32:27 +0000, Pasha Tatashin
> <[email protected]> wrote:
> > Move the radix tree tracker implementation from the core KHO code
>
> It's radix tree data structure implementation, kho memory tracker is it's
> user. Please rephrase to keep the semantics clear.
Yeap, I will update it.
>
> >
> >
> > diff --git a/kernel/liveupdate/Makefile b/kernel/liveupdate/Makefile
> > index eec9d3ae07eb..a3ee8a5c27a2 100644
> > --- a/kernel/liveupdate/Makefile
> > +++ b/kernel/liveupdate/Makefile
> > @@ -7,7 +7,11 @@ luo-y :=
> > \
> > luo_flb.o \
> > luo_session.o
> >
> > -obj-$(CONFIG_KEXEC_HANDOVER) += kexec_handover.o
> > +kho-y := \
> > + kexec_handover.o \
>
> I don't see much value in moving kexec_handover.o to a separate line,
> btw, the same is true for luo_core.o, but it's not important enough to
> change.
This is purely for consistency. I wanted to use the exact same style in
the Makefile instead of having two different ways of declaring the
object lists.
This:
luo-y := \
luo_core.o \
luo_file.o \
luo_flb.o \
luo_session.o
kho-y := \
kexec_handover.o \
kho_radix.o \
kho_block.o \
kho_vmalloc.o
Or this:
obj-$(CONFIG_LIVEUPDATE) += luo_core.o
obj-$(CONFIG_LIVEUPDATE) += luo_file.o
obj-$(CONFIG_LIVEUPDATE) += luo_flb.o
obj-$(CONFIG_LIVEUPDATE) += luo_session.o
obj-$(CONFIG_KEXEC_HANDOVER) += kexec_handover.o
obj-$(CONFIG_KEXEC_HANDOVER) += kho_radix.o
obj-$(CONFIG_KEXEC_HANDOVER) += kho_vmalloc.o
obj-$(CONFIG_KEXEC_HANDOVER) += kho_block.o
I do not care which way is chosen as long as it is consistent. Since
this series adds new separate files for KHO, and does not touch LUO, I
used LUO as template, but we can do the other way around.
