On 03/06/2026 22:53, Frank Li wrote:
+ {CSIPHY_LN1_CSI_3PH_CTRLn_ADDR(25), 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {CSIPHY_LN1_CSI_3PH_CTRLn_ADDR(55), 0x51, 0x00, CSIPHY_DEFAULT_PARAMS},
what's these magic number in ADDR(x), if it is register, it'd better to use
macro.
That's not really feasible for non-Qualcomm, non-vendor document-enabled
people to provide. For alot of the code that gets sent to upstream we
have magic-numbers for registers only, published in downstream code.
We can't demand better documentation from community members who simply
don't have it.
So, hex values from downstream in this case are acceptable.
OTOH vendors can and should enumerate their registers in an upstream
submission.
---
bod
