On Mon, May 18, 2026 at 3:41 PM Xiaobo Liu <[email protected]> wrote: > > Replace pr_warn!() with pr_warn_once!() in module_param::set_param() to > avoid flooding the kernel log when a null pointer is repeatedly passed. > > The original code had a TODO comment noting that pr_warn_once should be > used once available. Since pr_warn_once!() is now available, switch to it > and update the comment accordingly. > > Signed-off-by: Xiaobo Liu <[email protected]>
Isn't this https://lore.kernel.org/rust-for-linux/[email protected]/ and this: https://lore.kernel.org/rust-for-linux/[email protected]/ ? Cc'ing the authors of both. I will reply in the second one too. (Also, your email seems to have been sent twice to the list) In any case, Sashiko is correct, this "time-based comment" is not very useful: > + // `pr_warn_once` is already available, use it. Cheers, Miguel
