On Thu, Apr 30, 2026 at 03:14:59PM +0530, Sneh Mankad wrote: > From: Vishnu Santhosh <[email protected]> > > Enable Shikra APCS IPC support by adding the compatible. > It reuses apps_shared_apcs_data.
This is obvious from the patch itself. Tell us something, which is not written in the patch. For example, why it uses the same data structure. Or why we need separate compat string and entry in the driver. > > Signed-off-by: Vishnu Santhosh <[email protected]> > Signed-off-by: Sneh Mankad <[email protected]> > --- > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c > b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > index > d3a8f6b4a03b368821ef9a5b24fee78037104610..25f76965921ba695e3a1bf4df47ce643916a28cb > 100644 > --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c > +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > @@ -168,6 +168,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] > = { > { .compatible = "qcom,ipq8074-apcs-apps-global", .data = > &ipq6018_apcs_data }, > { .compatible = "qcom,sc7180-apss-shared", .data = > &apps_shared_apcs_data }, > { .compatible = "qcom,sc8180x-apss-shared", .data = > &apps_shared_apcs_data }, > + { .compatible = "qcom,shikra-apss-shared", .data = > &apps_shared_apcs_data }, > { .compatible = "qcom,sm8150-apss-shared", .data = > &apps_shared_apcs_data }, > {} > }; > > -- > 2.34.1 > -- With best wishes Dmitry
