07.04.2026 17:31, Luigi Leonardi wrote:
> `virtio_transport_send_pkt_info` gets all the transport information
> from the parameter `t_ops`. There is no need to call
> `virtio_transport_get_ops()`.
Hm, one more suggestion, but not in this patch: may be we can also remove
'struct vsock_sock *vsk' argument
from 'virtio_transport_send_pkt_info()', because it is also included in
'virtio_vsock_pkt_info *info' ?
Thanks
>
> Remove it.
>
> Fixes: 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY flag support")
> Signed-off-by: Luigi Leonardi <[email protected]>
> ---
> I marked this as net-next material, but honsetly I'm not sure if I
> should have targeted net. It's not a bug after all, it's just a cleanup.
> ---
> net/vmw_vsock/virtio_transport_common.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/vmw_vsock/virtio_transport_common.c
> b/net/vmw_vsock/virtio_transport_common.c
> index 8a9fb23c6e85..a152a9e208d0 100644
> --- a/net/vmw_vsock/virtio_transport_common.c
> +++ b/net/vmw_vsock/virtio_transport_common.c
> @@ -60,8 +60,6 @@ static bool virtio_transport_can_zcopy(const struct
> virtio_transport *t_ops,
> return false;
>
> /* Check that transport can send data in zerocopy mode. */
> - t_ops = virtio_transport_get_ops(info->vsk);
> -
> if (t_ops->can_msgzerocopy) {
> int pages_to_send = iov_iter_npages(iov_iter, MAX_SKB_FRAGS);
>
>
> ---
> base-commit: bfe62a454542cfad3379f6ef5680b125f41e20f4
> change-id: 20260407-remove_parameter-f61a3e40cf90
>
> Best regards,
Acked-by: Arseniy Krasnov <[email protected]>
