On Thu, Apr 02, 2026 at 11:19:42AM +0200, Krzysztof Kozlowski wrote: > On Wed, Apr 01, 2026 at 08:01:34PM -0700, Francisco Munoz Ruiz wrote: > > Add documentation for the Last Level Cache Controller (LLCC) bindings to > > support Hawi and upcoming Qualcomm SoCs where the System Cache Table (SCT) > > is programmed by firmware outside of Linux. > > > > Introduce a property that specifies the base address of the shared memory > > region from which the driver should read SCT descriptors provided by > > firmware. > > Subject - I do not see any future SoCs in the binding. Which future SoCs > are you documenting here? > You're right. The "future SoCs" wording is not justified by what is currently documented. I'll drop that wording. > > > > Signed-off-by: Francisco Munoz Ruiz <[email protected]> > > Reviewed-by: Konrad Dybcio <[email protected]> > > --- > > .../devicetree/bindings/cache/qcom,llcc.yaml | 29 > > ++++++++++++++++++---- > > 1 file changed, 24 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > > b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > > index 995d57815781..ca1313de10ca 100644 > > --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > > +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > > @@ -11,16 +11,17 @@ maintainers: > > > > description: | > > LLCC (Last Level Cache Controller) provides last level of cache memory > > in SoC, > > - that can be shared by multiple clients. Clients here are different cores > > in the > > - SoC, the idea is to minimize the local caches at the clients and migrate > > to > > - common pool of memory. Cache memory is divided into partitions called > > slices > > - which are assigned to clients. Clients can query the slice details, > > activate > > - and deactivate them. > > + that can be shared by multiple clients. Clients here are different cores > > in > > + the SoC. The idea is to minimize the local caches at the clients and > > migrate > > + to a common pool of memory. Cache memory is divided into partitions > > called > > + slices which are assigned to clients. Clients can query the slice > > details, > > + activate and deactivate them. > > I don't get why you are changing this. I read it and still cannot find > the difference. > > Introducing irrelevant changes only obfuscates the work you are doing > here. > > Best regards, > Krzysztof > Agreed — The description change is unnecessary. I'll fix both in a V2 of the series once more feedback is collected.
Thank you, Francisco.
