On 3/9/26 10:36 PM, [email protected] wrote: > On 2026-03-09 22:19, [email protected] wrote: >> On 2026-03-09 13:53, Konrad Dybcio wrote: >>> On 3/5/26 6:28 PM, Barnabás Czémán wrote: >>>> Redmi Go (tiare) is like Redmi 5A with small differences like charging, >>>> fuel gauge and different speaker codec. >>>> >>>> Signed-off-by: Barnabás Czémán <[email protected]> >>>> --- >>>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>>> arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts | 27 >>>> +++++++++++++++++++++++ >>>> 2 files changed, 28 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile >>>> b/arch/arm64/boot/dts/qcom/Makefile >>>> index 20e161e843ed..a74598cf0b47 100644 >>>> --- a/arch/arm64/boot/dts/qcom/Makefile >>>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>>> @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_QCOM) += >>>> msm8916-wingtech-wt88047.dtb >>>> dtb-$(CONFIG_ARCH_QCOM) += msm8916-yiming-uz801v3.dtb >>>> dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-riva.dtb >>>> dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-rolex.dtb >>>> +dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-tiare.dtb >>>> dtb-$(CONFIG_ARCH_QCOM) += msm8929-wingtech-wt82918hd.dtb >>>> dtb-$(CONFIG_ARCH_QCOM) += msm8937-xiaomi-land.dtb >>>> dtb-$(CONFIG_ARCH_QCOM) += msm8939-asus-z00t.dtb >>>> diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts >>>> b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts >>>> new file mode 100644 >>>> index 000000000000..c3a74530c34c >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts >>>> @@ -0,0 +1,27 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-only >>>> +/* >>>> + * Copyright (c) 2026, Barnabas Czeman >>>> + */ >>>> + >>>> +/dts-v1/; >>>> + >>>> +#include "msm8917-xiaomi-riva-common.dtsi" >>>> + >>>> +/ { >>>> + model = "Xiaomi Redmi Go (tiare)"; >>>> + compatible = "xiaomi,tiare", "qcom,msm8917"; >>>> + >>>> + qcom,board-id = <0x1000b 1>; >>> >>> Could you please double-check this? Riva and Rolex seem to have >>> properly different values there, but this one mimics one of the >>> values for Rolex. >> riva value is depends from the bootloader, Oreo bootloader using same value >> like rolex and tiare, 2nd entry in the board-id is not used so i should >> remove it. >> Here is some more context: >> https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8952/msm8917-xiaomi-riva.dts >> https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8952/msm8917-xiaomi-common.dts >> > I have find out this qcom,board-id = <0x1000b 1>, <0x1000b 2>; works with > both bootloader version > on riva but if i set only one of them, the bootloader version will be limited.
These properties exist for the sole reason of making the bootloader happy, so if there's nuance, let's not try being too smart and just stick with what works Konrad
