On Tue, Feb 05, 2008 at 06:20:15PM -0500, [EMAIL PROTECTED] wrote: > > The expectation of this driver is that the battery monitor driver will > > register as the "wm97xx-battery" device and use the wm97xx_read_aux_adc() > > function exported by the wm97xx-core driver to access the ADC. Is your > > driver using this interface?
> Yes, but this makes the wm97xx-battery device depend on configuring in the > touchscreen. Indeed. Could you expand on why this is a problem? > The problem we're having is that when we updated wm97xx-core.c from > version 0.62 to 0.65 the ADC values returned by wm97xx_read_aux_adc() to > the battery driver changed. We did modify both versions to make the Version 0.62 predates our git history so I don't have the old version to hand. I can't spot anything obvious in the information I do have except perhaps something introduced when the drivers were split to start pulling out the codec parts. > struct wm97xx * global so the battery monitor could pass it to > wm97xx_read_aux_adc() (is there a better way?). Well, other than using wm97xx-battery to find it not really. To be honest I don't really see what this buys you over using the battery device since what you suggest means you need to wait until it is registered anyway. > > The intention is that these drivers should be able to coexist with the > > existing ASoC drivers as-is. We do have existing users doing this - the > They don't just coexist with soc, they depend on it. If you configure out > the AC97 driver under soc the touchscreen and battery drivers won't work > (but they'll build). What sorts of problems are you seeing? I've done a very large proportion of my touchscreen work with ASoC completely disabled and haven't noticed any issues. In this case I was using the non-ASoC PXA AC97 driver (CONFIG_SND_AC97_CODEC, sound/arm/pxa2xx-ac97.c). Within ASoC it should be possible to use the generic AC97 codec driver but I can't say I've ever tested that. > We used the same architecture as tosa and retained > the OH guys for the app framework (and platform assistance - thanks RP :). OK, that's good - sounds like you're doing something fairly standard. > The first release is publicly available; the release I'm working on was > aimed for the 2.6.24 merge window but some key stuff (ARM clock/power > management, USB gadget) changed causing me to re-engineer. I'm still > troubleshooting some 2.6.18-->24 port issues here (pxa27x_ac97 errors on > resume - we use deep sleep, not sleep on the pxa270), but can publicize a > source tarball and send you the link. Yes, that'd be really helpful. I don't have the hardware so any non working stuff isn't going to affect me too much :) . -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
