> diff --git a/tools/include/uapi/linux/module_signature.h
> b/tools/include/uapi/linux/module_signature.h
> --- /dev/null
> +++ b/tools/include/uapi/linux/module_signature.h
[ ... ]
> +enum module_signature_type {
> + MODULE_SIGNATURE_TYPE_PKCS7 = 2, /* Signature in PKCS#7 message
> */
> + MODULE_SIGNATURE_TYPE_MERKLE = 3, /* Merkle proof for modules */
> +};
The source UAPI header at include/uapi/linux/module_signature.h does not
define MODULE_SIGNATURE_TYPE_MERKLE:
include/uapi/linux/module_signature.h:
enum module_signature_type {
MODULE_SIGNATURE_TYPE_PKCS7 = 2,
};
Was this value intentionally added here ahead of the kernel header? It
appears to come from the CONFIG_MODULE_HASHES series referenced in the
cover letter, but no commit in this series adds it to the kernel UAPI
header, so the tools copy diverges from its source at creation time.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/22577240517
AI-authorship-score: low
AI-authorship-explanation: Straightforward mechanical UAPI header copy with
terse commit message, consistent with experienced kernel developer style from a
known Linutronix contributor.
issues-found: 1
issue-severity-score: low
issue-severity-explanation: The tools UAPI copy contains an enum value
(MODULE_SIGNATURE_TYPE_MERKLE) not present in the kernel source header,
creating a content mismatch that does not affect runtime behavior but violates
the convention that tools copies mirror kernel UAPI headers.
