On 12/23/2025 9:29 PM, Krzysztof Kozlowski wrote:
> On Tue, Dec 23, 2025 at 01:13:49AM -0800, Jingyi Wang wrote:
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
>> b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
>> index 63a82e7a8bf8..149e993282bb 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
>> @@ -33,16 +33,22 @@ properties:
>> - description: Handover interrupt
>> - description: Stop acknowledge interrupt
>> - description: Shutdown acknowledge interrupt
>> + - description: Pong interrupt
>> + - description: Wake acknowledge interrupt
>>
>> interrupt-names:
>> minItems: 5
>> + maxItems: 7
>> items:
>> - - const: wdog
>> - - const: fatal
>> - - const: ready
>> - - const: handover
>> - - const: stop-ack
>> - - const: shutdown-ack
>> + enum:
>
> No, no. Stop doing random changes. NAK
>
> Now you remove strict order (see writing bindings) and claim every
> device like SM8550 ADSP PAS has any order.
>
> And it is now de-synced with interrupts. Read writing bindings - this is
> clearly described there at line 90!
>
> You can only grow existing list.
>
>
>
the interrupt for soccp is defined as
"wdog","fatal","ready","handover","stop-ack","pong","wake-ack"
while other pas could be:
"wdog","fatal","ready","handover","stop-ack","shutdown-ack"
so grow existing list is not work for this,
In the v1, got your comments to adjust pas-common.yaml for the interrupt:
https://lore.kernel.org/all/[email protected]/
and in v2, interrupt are moved as part to the "allOf" with if-else and
also got NAK:
https://lore.kernel.org/all/20251030-venomous-apricot-falcon-b3fd64@kuoka/
Could you please share a example for us to understand how to maintain it in
pas-common.yaml, not define if-else and has strict order at the same time?
That will be very helpful.
Thanks,
Jingyi
>> + - wdog
>> + - fatal
>> + - ready
>> + - handover
>> + - stop-ack
>> + - shutdown-ack
>> + - pong
>> + - wake-ack
>>
>> power-domains:
>> minItems: 1
>> @@ -55,13 +61,21 @@ properties:
>> qcom,smem-states:
>> $ref: /schemas/types.yaml#/definitions/phandle-array
>> description: States used by the AP to signal the Hexagon core
>> + minItems: 1
>> items:
>> - - description: Stop the modem
>> + - description: Stop the remoteproc
>> + - description: Wake up the remoteproc
>> + - description: Make the remoteproc sleep
>> + - description: Ping the remoteproc
>
> So every device like SM8550 PAS has now four smem states... without any
> explanation. Read writing bindings - what does it say?
>
This change is similar to current interrupt-names property define 6 interrupts
but has minItems: 5
- interrupt-names:
- minItems: 5
- items:
- - const: wdog
- - const: fatal
- - const: ready
- - const: handover
- - const: stop-ack
- - const: shutdown-ack
I think this should be "grow existing list" you mentioned above?
Thanks,
Jingyi
> "... and define constraints specific to the device."
>
> "DO define properties in terms of constraints. How many entries? What are
> possible values? What is the order? All these constraints represent the ABI
> as well."
>
> It is your homework to read the docs. Not mine.
>
> If you want to change common list you must define strict constraints for
> EVERY user.
>
> Best regards,
> Krzysztof
>
