Hi Xiaochen,
On 12/12/25 11:38 PM, Xiaochen Shen wrote:
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c
> b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 5154ffd821c4..980ecf2bcf10 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -23,16 +23,24 @@ static struct resctrl_test *resctrl_tests[] = {
> &l2_noncont_cat_test,
> };
>
> -static int detect_vendor(void)
> +static unsigned int detect_vendor(void)
> {
> - FILE *inf = fopen("/proc/cpuinfo", "r");
> - int vendor_id = 0;
> + FILE *inf;
> + static unsigned int vendor_id;
> char *s = NULL;
> char *res;
> + static bool initialized;
>
The changelog incorrectly claims that this should now match reverse fir
ordering.
To be "reverse fir" ordered the declarations should look like:
static unsigned int vendor_id;
static bool initialized;
char *s = NULL;
FILE *inf;
char *res;
With this fixed:
| Reviewed-by: Reinette Chatre <[email protected]>
Reinette
