[+Onur - sorry I didn't Cc you when sending this series]
On 10/12/2025 2:58 pm, Guillaume Tucker wrote:
+def run_docker(args):
+ """Run a command in a Docker container"""
+ uid = args.uid or os.getuid()
+ gid = args.gid or args.uid or os.getgid()
+ cmd = [
+ 'docker', 'run',
+ '--interactive',
+ '--volume', f'{os.getcwd()}:/src',
+ '--workdir', '/src',
+ '--user', f'{uid}:{gid}'
+ ]
+ if args.env_file:
+ cmd += ['--env-file', args.env_file]
+ cmd.append(args.image)
+ cmd += args.cmd
+ return subprocess.call(cmd)
Just realised that it also needs a TTY to handle Ctrl-C signals
correctly, otherwise the Python process would stop but the container
would keep running in a detached process (same for podman):
diff --git a/scripts/container b/scripts/container
index 74644ac33685..e05425c06d28 100755
--- a/scripts/container
+++ b/scripts/container
@@ -30,6 +30,7 @@ def run_docker(args):
cmd = [
'docker', 'run',
'--interactive',
+ '--tty',
'--volume', f'{os.getcwd()}:/src',
'--workdir', '/src',
'--user', f'{uid}:{gid}'
I'll send a v2 next week, but I'll wait a bit for any feedback first.
Thanks,
Guillaume
