Now that such info is in the 'flags' attribute, it is time to deprecate
the dedicated 'server-side' attribute.

It will be removed in a few versions.

Reviewed-by: Geliang Tang <geli...@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matt...@kernel.org>
---
 Documentation/netlink/specs/mptcp_pm.yaml | 1 +
 net/mptcp/pm_netlink.c                    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/netlink/specs/mptcp_pm.yaml 
b/Documentation/netlink/specs/mptcp_pm.yaml
index 
fc47a2931014c0304efd3215cc24485ea22e1ede..ba30a40b9dbf2d2d4f25cc07b309ea560712f65e
 100644
--- a/Documentation/netlink/specs/mptcp_pm.yaml
+++ b/Documentation/netlink/specs/mptcp_pm.yaml
@@ -266,6 +266,7 @@ attribute-sets:
       -
         name: server-side
         type: u8
+        doc: "Deprecated: use 'flags'"
 
 operations:
   list:
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 
aa0c73faaa6acad3fd66ea0942726ecd4d0abcc0..d5b383870f79956ce5e10bf384695621604f3ce9
 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -416,7 +416,7 @@ static int mptcp_event_created(struct sk_buff *skb,
        if (READ_ONCE(msk->pm.server_side)) {
                flags |= MPTCP_PM_EV_FLAG_SERVER_SIDE;
 
-               /* only set when it is the server side */
+               /* Deprecated, and only set when it is the server side */
                if (nla_put_u8(skb, MPTCP_ATTR_SERVER_SIDE, 1))
                        return -EMSGSIZE;
        }

-- 
2.51.0


Reply via email to