On Sat, Sep 06, 2025 at 05:41:48PM +0400, Fidal Palamparambil wrote: > From: Fidal palamparambil <rootuserh...@gmail.com> > > This commit addresses several bugs and potential issues in the > trace_printk module format handling code: > > 1. Memory leak fix: In hold_module_trace_bprintk_format(), ensure > proper cleanup when format string allocation fails by setting > tb_fmt to NULL after freeing it. > > 2. NULL pointer dereference prevention: Added NULL checks in > t_show() function before dereferencing format pointers. > > 3. Input validation: Added NULL check in trace_is_tracepoint_string() > to prevent potential NULL pointer dereference. > > 4. Type safety: Fixed type casting in t_show() to use proper > unsigned long casting for pointer arithmetic. > > 5. Error handling: Improved error checking in > init_trace_printk_function_export() by using IS_ERR() to check > dentry pointer. > > 6. Code robustness: Added additional pointer validation throughout > the code to handle potential edge cases. > > 7. Memory safety: Ensured consistent handling of format pointers > when memory allocation failures occur. > > These fixes improve the stability and reliability of the trace_printk > infrastructure, particularly when dealing with module loading/unloading > and format string management. > > Signed-off-by: Fidal palamparambil <rootuserh...@gmail.com>
Anothe waste of time. Stop. I'll suggest everyone ignore your patches. Luis
