On Sun, Aug 31, 2025 at 11:06:41AM +0300, Carolina Jubran wrote:
> This test is meant to check TC bandwidth distribution, not the tx_max
> of the VF. The total bandwidth check is only there to make sure that FW
> tokens limit traffic, because the per-TC share is only meaningful when
> the link is fully saturated.
> 
> Because the measured total is the sum of two iperf3 streams that do not
> always start or stop at the same time, using a strict 1 Gbps target
> caused random failures. This change adds a tolerance parameter to
> BandwidthValidator, keeps per-TC checks tight at +-12%, and relaxes the
> total bandwidth check to +-25% around 1 Gbps.
> 
> This avoids false failures while still confirming that the TC share
> validation is meaningful.
> 
> Fixes: 23ca32e4ead4 ("selftests: drv-net: Add test for devlink-rate traffic 
> class bandwidth distribution")
> Tested-by: Carolina Jubran <cjub...@nvidia.com>
> Signed-off-by: Carolina Jubran <cjub...@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cra...@nvidia.com>
> Reviewed-by: Nimrod Oren <no...@nvidia.com>

Reviewed-by: Simon Horman <ho...@kernel.org>


Reply via email to