On Saturday, 30 August 2025 16:53:48 Central European Summer Time Andy Shevchenko wrote: > On Sat, Aug 30, 2025 at 4:04 PM Duje Mihanović <d...@dujemihanovic.xyz> wrote: > > On Saturday, 30 August 2025 06:37:27 Central European Summer Time Andy > > Shevchenko wrote: > > > On Fri, Aug 29, 2025 at 2:41 AM David Lechner <dlech...@baylibre.com> > > > wrote: > > > > On 8/28/25 5:17 PM, Duje Mihanović wrote: > > > > > +config 88PM886_GPADC > > > > > + tristate "Marvell 88PM886 GPADC driver" > > > > > + depends on MFD_88PM886_PMIC > > > > > + default y > > > > > > Really? Why tristate then? > > > I would expect default MFD_88PM886_PMIC instead, > > > > > > > > + help > > > > > + Say Y here to enable support for the GPADC (General Purpose > > > > > ADC) > > > > > + found on the Marvell 88PM886 PMIC. The GPADC measures various > > > > > + internal voltages and temperatures, including (but not limited > > > > > to) > > > > > + system, battery and USB. > > > > > > Please, add a line about the module name if one chooses 'm'. Or see > > > above — drop the "tristate" and explain why this driver may not be a > > > module in the commit message. > > > > 'default MFD_88PM886_PMIC' would make it y as that one is a bool. How > > about 'default m if MFD_88PM886_PMIC' or, since this already depends on > > _PMIC, 'default m'? > > I didn't get it. Why? defaulting to MFD is okay, otherwise one needs > to explain 'y' (and even explicit 'm' choice) for the _leaf_ driver.
I just wanted to keep the driver as modular as possible, including by default. Regardless, this sounds OK to me. Regards, -- Duje
