On Thu Aug 28, 2025 at 10:54 PM UTC, Andrew Morton wrote: > On Thu, 28 Aug 2025 14:49:37 -0400 "Liam R. Howlett" > <liam.howl...@oracle.com> wrote: > >> * Brendan Jackman <jackm...@google.com> [250828 08:37]: >> > On Sun Aug 17, 2025 at 6:52 AM UTC, Ujwal Kundur wrote: >> > > -static void noop_alias_mapping(__u64 __unused *start, size_t __unused >> > > len, >> > > - unsigned long __unused offset) >> > > +static void noop_alias_mapping(uffd_global_test_opts_t *gopts, __u64 >> > > __unused *start, >> > > + size_t __unused len, unsigned long >> > > __unused offset) >> > >> > After a rebase this is now falling afoul of the -Wunused-parameter added >> > here: >> > >> > https://lore.kernel.org/all/20250731160132.1795351-5-usama.an...@collabora.com/T/#m0449dc0d6a5ac3b1f71f7182c13b6829e1b444cf >> > >> > I really don't think we want that flag, I'll comment on that thread, but >> > just as an FYI here too. >> >> I was under the impression that it was decided to drop that flag, >> otherwise I would have also spoken up about it. > > err, yes, I thought I'd dropped that. > > No -Wunused-parameter, please. > > The v2 series needs work and a v3 series is expected so I'll drop the > v2 series "selftests/mm: Add compiler flags and fix found warnings".
Ah yep I said I'd reply to the other thread but upon re-reading it I realised you were already against -Wunused-parameter, thanks for dropping it.
