On Sun, Aug 24, 2025 at 06:12:05PM +0200, Duje Mihanović wrote: > The binding currently expects exactly 5 keycodes, which matches the > chip's theoretical maximum but probably not the number of touch keys on > any phone using the IST3032C. Add a minItems value of 2 to prevent > dt-validate complaints.
Does this mean that there are devicetrees in the wild that use < 5
keycodes?
>
> Also add another example to make sure the linux,keycodes property is
> checked.
>
> Signed-off-by: Duje Mihanović <d...@dujemihanovic.xyz>
> ---
> .../bindings/input/touchscreen/imagis,ist3038c.yaml | 18
> ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> index
> bd8ede3a4ad8939cef97e9b177548a8fc8386df7..0ef79343bf9a223501aff8b6a525b873e777ea20
> 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> @@ -35,6 +35,7 @@ properties:
>
> linux,keycodes:
> description: Keycodes for the touch keys
> + minItems: 2
> maxItems: 5
>
> touchscreen-size-x: true
> @@ -87,5 +88,22 @@ examples:
> touchscreen-inverted-y;
> };
> };
> + - |
> + #include <dt-bindings/input/linux-event-codes.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + touchscreen@50 {
> + compatible = "imagis,ist3032c";
> + reg = <0x50>;
> + interrupt-parent = <&gpio>;
> + interrupts = <72 IRQ_TYPE_EDGE_FALLING>;
> + vdd-supply = <&ldo2>;
> + touchscreen-size-x = <480>;
> + touchscreen-size-y = <800>;
> + linux,keycodes = <KEY_APPSELECT>, <KEY_BACK>;
Does this really need a dedicated example? Why can't the property go
into the existing one?
> + };
> + };
>
> ...
>
> ---
> base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
> change-id: 20250824-imagis-minitems-4a71387ce61b
>
> Best regards,
> --
> Duje Mihanović <d...@dujemihanovic.xyz>
>
signature.asc
Description: PGP signature
