Ingo Molnar wrote:
another thing: these inlines are a bit fat and they are used in more than one place. Please move them into pgtable.c. The rule of thumb is: if an inline is more than 2 lines big, it is a likely candidate for uninlining. (and even many 2-liners, and even some 1-liners are candidates) Especially under paravirt the MMU inlines grow these update notifiers so they become even fatter.
I agree, but I wanted to keep it semantically equivalent to the original. I'll add a move to out of line patch.
having functions instead of inlines also simplifies the type dependencies by quite a degree.
Indeed, the floating asm/tlbflush.h is a bit of a wart. J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
