> -----Original Message-----
> From: Mathieu Poirier <mathieu.poir...@linaro.org>
> Sent: Wednesday, August 20, 2025 3:49 PM
> To: Shenwei Wang <shenwei.w...@nxp.com>
> Cc: Bjorn Andersson <anders...@kernel.org>; Rob Herring <r...@kernel.org>;
> Krzysztof Kozlowski <krzk...@kernel.org>; Conor Dooley
> <conor...@kernel.org>; Shawn Guo <shawn...@kernel.org>; Sascha Hauer
> <s.ha...@pengutronix.de>; Linus Walleij <linus.wall...@linaro.org>; Bartosz
> Golaszewski <b...@bgdev.pl>; Pengutronix Kernel Team
> <ker...@pengutronix.de>; Fabio Estevam <feste...@gmail.com>; Peng Fan
> <peng....@nxp.com>; linux-remotep...@vger.kernel.org;
> devicet...@vger.kernel.org; i...@lists.linux.dev; linux-arm-
> ker...@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux-imx <linux-
> i...@nxp.com>
> Subject: [EXT] Re: [PATCH 0/4] Enable Remote GPIO over RPMSG on i.MX
> Platform
>
>
> Did you send me a patchset that doesn't clear checkpatch.pl?
>
There is one known warning:
WARNING: function definition argument 'struct rpmsg_device *' should also have
an identifier name
#268: FILE: include/linux/imx_rpmsg.h:51:
+ int (*rx_callback)(struct rpmsg_device *, void *, int, void *, u32);
I just kept the format as the existing style. If it is required to be fixed, I
will update it in next version.
Regards,
Shenwei
> On Mon, Aug 18, 2025 at 03:44:16PM -0500, Shenwei Wang wrote:
> > Support the remote devices on the remote processor via the RPMSG bus
> > on i.MX platform.
> >
> > The expected DTS layout structure is following:
> >
> > cm33: remoteproc-cm33 {
> > compatible = "fsl,imx8ulp-cm33";
> >
> > rpmsg {
> > rpmsg-io-channel {
> > gpio@0 {
> > compatible = "fsl,imx-rpmsg-gpio";
> > reg = <0>;
> > };
> >
> > gpio@1 {
> > compatible = "fsl,imx-rpmsg-gpio";
> > reg = <1>;
> > };
> >
> > ...
> > };
> >
> > rpmsg-i2c-channel {
> > i2c@0 {
> > compatible = "fsl,imx-rpmsg-i2c";
> > reg = <0>;
> > };
> > };
> >
> > ...
> > };
> > };
> >
> >
> > Shenwei Wang (4):
> > dt-bindings: remoteproc: imx_rproc: Add "rpmsg" subnode support
> > remoteproc: imx_rproc: Populate devices under "rpmsg" subnode
> > gpio: imx-rpmsg: add imx-rpmsg GPIO driver
> > arm64: dts: imx8ulp: Add rpmsg node under imx_rproc
> >
> > .../bindings/remoteproc/fsl,imx-rproc.yaml | 117 ++++
> > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 27 +
> > drivers/gpio/Kconfig | 11 +
> > drivers/gpio/Makefile | 1 +
> > drivers/gpio/gpio-imx-rpmsg.c | 559 ++++++++++++++++++
> > drivers/remoteproc/imx_rproc.c | 125 ++++
> > include/linux/imx_rpmsg.h | 55 ++
> > 7 files changed, 895 insertions(+)
> > create mode 100644 drivers/gpio/gpio-imx-rpmsg.c create mode 100644
> > include/linux/imx_rpmsg.h
> >
> > --
> > 2.43.0
> >
