> > > > > > > > + * Return: > > > + * * %0: - Success or not supported > > > + * * %-EAGAIN: - Can be safely retried, failure is due to lack > > > of > > > + * * entropy in RNG > > > > Nit: if another version is ever needed, I think it would be better to make > > the text vertical aligned w/o the leading '-', i.e., > > > > * %-EAGAIN: - Can be .... > > entropy in RNG. > > > > .. instead of > > > > * %-EAGAIN: - Can be .... > > entropy in RNG. > > OK, yes, this can be fixed, indeed. >
I downloaded those patches and checked locally. I found there's an unnecessary 'tab' between the error codes and the descriptions, making the whitespace between them unnecessarily too long. Please see below diff I came up with: diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sgx/main.c index cff5c4d22ac2..c6467628da04 100644 --- a/arch/x86/kernel/cpu/sgx/main.c +++ b/arch/x86/kernel/cpu/sgx/main.c @@ -929,10 +929,10 @@ static int sgx_usage_count; * cryptographic assets. * * Return: - * * %0: - Success or not supported - * * %-EAGAIN: - Can be safely retried, failure is due to lack of - * * entropy in RNG - * * %-EIO: - Unexpected error, retries are not advisable + * * %0: - Success or not supported + * * %-EAGAIN: - Can be safely retried, failure is due to lack of + * * entropy in RNG + * * %-EIO: - Unexpected error, retries are not advisable */ static int sgx_update_svn(void) {