On 28/07/2025 13:03, Junhui Liu wrote:
> +
> + firmware-name:
> + maxItems: 1
> +
> + mbox-names:
> + items:
> + - const: tx
> + - const: rx
> +
> + mboxes:
First go mboxes, then mboxes-names. ALWAYS.
> + description:
> + This property is required only if the rpmsg/virtio functionality is
> used.
> + (see mailbox/sophgo,cv1800b-mailbox.yaml)
> + items:
> + - description: mailbox channel to send data to C906L
> + - description: mailbox channel to receive data from C906L
> +
> + memory-region:
> + description:
> + List of phandles to reserved memory regions used by the remote
> processor.
> + The first region is required and provides the firmware region for the
> + remote processor. The following regions (vdev buffer, vrings) are
> optional
> + and are only required if rpmsg/virtio functionality is used.
> + minItems: 1
Why isn't this constrained?
> + items:
> + - description: firmware region
> + - description: vdev buffer
> + - description: vring0
> + - description: vring1
> + additionalItems: true
No, drop. This needs to be constrained.
> +
> + resets:
> + maxItems: 1
> +
> + sophgo,syscon:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + A phandle to the SEC_SYS region, used for configuration of the remote
> + processor.
> +
> +required:
> + - compatible
> + - firmware-name
> + - memory-region
> + - resets
> + - sophgo,syscon
Why mboxes are not required?
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + c906l-rproc {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
