On Thu, Jun 05, 2025 at 03:27:19PM -0500, Bjorn Andersson wrote:
> On Thu, Jun 05, 2025 at 06:01:07PM +0200, Luca Weiss wrote:
> > Hi Bjorn,
> >
> > Awesome to see this being cleaned up!
> >
> > On 05-06-2025 5:23 p.m., Bjorn Andersson wrote:
> > > The change that renamed the driver from "adsp" to "pas" didn't change
> > > any of the implementation. The result is an aesthetic eyesore, and
> > > confusing to many.
> > >
> > > Conclude the rename of the driver, by updating function, structures and
> > > variable names to match what the driver actually is. The "Hexagon v5" is
> > > also dropped from the name and Kconfig, as this isn't correct either.
> > >
> > > No functional change.
> > >
> > > Fixes: 9e004f97161d ("remoteproc: qcom: Rename Hexagon v5 PAS driver")
> > > Signed-off-by: Bjorn Andersson <bjorn.anders...@oss.qualcomm.com>
> > > ---
> > > drivers/remoteproc/Kconfig | 11 +-
> > > drivers/remoteproc/qcom_q6v5_adsp.c | 46 +--
> >
> > Actually looking through that driver, it's not just adsp-pil but also
> > supports cdsp-pil and wpss-pil, so long-term that should probably be renamed
> > to qcom_q6v5_pil.c? Not for this patch though obviously.
> >
>
> There's another "convention" at play here, the "pas" refers to the
> secure service doing authentication. The alternative to this is to do
> everything in Linux, which we conveniently refer to (here) as "pil".
>
> Also, per the commit text the "q6v5" isn't accurate anymore, so perhaps
> this should just be the qcom_pas driver - or the qcom_pil driver.
>
> I think the change as proposed is a good middle ground, we get things
> cleaned up and aligned without affecting anything outside the
> implementation.
>
Sorry, didn't spot my mistake until Wasim pointed it out, I didn't
intend to touch this file.
Yes, the qcom_q6v5_adsp driver suffers the same problem as the "adsp
pas" driver did.
I like your suggestion.
Regards,
Bjorn
