On Tue, May 20, 2025 at 10:30:30PM +0300, Vladimir Zapolskiy wrote:
> Hello Vincent.
>
> On 5/20/25 21:39, Vincent Knecht via B4 Relay wrote:
> > From: Vincent Knecht <vincent.kne...@mailoo.org>
> >
> > Add the camera subsystem and CCI used to interface with cameras on the
> > Snapdragon 615.
> >
> > Signed-off-by: Vincent Knecht <vincent.kne...@mailoo.org>
> > ---
> > arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi | 4 +
> > arch/arm64/boot/dts/qcom/msm8939.dtsi | 152
> > +++++++++++++++++++++++++++
>
> Please split SoC specific changes from the board specific ones into
> separate patches.
>
> > 2 files changed, 156 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi
> > b/arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi
> > index
> > adb96cd8d643e5fde1ac95c0fc3c9c3c3efb07e8..659d127b1bc3570d137ca986e4eacf600c183e5e
> > 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi
> > @@ -11,6 +11,10 @@
> > #include "msm8939.dtsi"
> > #include "pm8916.dtsi"
> > +&camss {
> > + vdda-supply = <&pm8916_l2>;
> > +};
> > +
>
> What is the benefit of enabling CAMSS on a board without any sensors
> connected to the SoC? Likely the board specific change has to be removed.
This is not a board, it's a PMIC-related include file which just wires
the supplies.
--
With best wishes
Dmitry
