On 5/12/25 5:20 AM, Lijuan Gao wrote:
>
>
> 在 5/9/2025 4:54 PM, Konrad Dybcio 写道:
>> On 5/9/25 9:37 AM, Lijuan Gao wrote:
>>>
>>>
>>> 在 5/8/2025 10:41 PM, Konrad Dybcio 写道:
>>>> On 5/7/25 12:26 PM, Lijuan Gao wrote:
>>>>> Add a simple-mfd representing IMEM on QCS615 and define the PIL
>>>>> relocation info region as its child. The PIL region in IMEM is used to
>>>>> communicate load addresses of remoteproc to post mortem debug tools, so
>>>>> that these tools can collect ramdumps.
>>>>>
>>>>> Signed-off-by: Lijuan Gao <quic_liju...@quicinc.com>
>>>>> ---
>>>>> arch/arm64/boot/dts/qcom/qcs615.dtsi | 14 ++++++++++++++
>>>>> 1 file changed, 14 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>>> b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>>> index 53661e3a852e..fefdb0fd66f7 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>>> @@ -3266,6 +3266,20 @@ sram@c3f0000 {
>>>>> reg = <0x0 0x0c3f0000 0x0 0x400>;
>>>>> };
>>>>> + sram@146aa000 {
>>>>> + compatible = "qcom,qcs615-imem", "syscon", "simple-mfd";
>>>>> + reg = <0x0 0x146aa000 0x0 0x1000>;
>>>>
>>>> 0x14680000 0x2c000
>>>
>>> I checked the latest datasheet, the Shared IMEM address is 0x146aa000 and
>>> its size is 0x1000, 0x14680000 is the start address of IMEM layout. The
>>> shared IMEM is used for debugging purposes, while the others parts are
>>> dedicated.
>>
>> Even if we don't use the entirety of it, it's good to describe
>> the whole block
>>
>> Konrad
>
> According to the definitions on all existing upstream platforms, this imem
> points to the shared imem. Should we stay consistent?
That is because everyone kept copying over whatever the downstream
kernel did ;)
Let's describe the whole region - at best, it doesn't hurt
Konrad
