On Mon, 12 May 2025 at 11:14, Dmitry Antipov <dmanti...@yandex.ru> wrote:
>
> Technically speaking you're right, and I will take notice on that for
> further commits. OTOH replying with "please adjust commit message and
> send v2" could be the way faster.
I suspect it ends up depending on the people.
Personally, I tend to dislike being on the receiving end of the
back-and-forth of "fix this nit before I'll apply things", so I
generally try to avoid doing that to others.
Yes, I will do it for things that I think matter, where I really don't
want to have some bad thing show up to then be fixed later.
But I feel we sometimes have *too* much of that code review attitude
going on, where you end up with patch series that go on for multiple
versions because people keep reacting to various small details.
So most of the time, I'd rather just get the code fixed - get it over
with and leave the issue behind.
I'll point out something I think was wrong, but not fatal to the
codebase, and hopefully just make people aware and avoid future
occurrences.
IOW, I didn't expect my comment to result in any particular action
this time, just a "please think more about the explanations".
Linus
