From: Brendan Jackman <jackm...@google.com>

[ Upstream commit 08fafac4c9f289a9d9a22d838921e4b3eb22c664 ]

As noted in [0], SeaBIOS (QEMU default) makes a mess of the terminal,
qboot does not.

It turns out this is actually useful with kunit.py, since the user is
exposed to this issue if they set --raw_output=all.

qboot is also faster than SeaBIOS, but it's is marginal for this
usecase.

[0] 
https://lore.kernel.org/all/ca+i-1c0wyb-gz8mwh3wsvpbk-lf-uo+njvbasjpe1wxduro...@mail.gmail.com/

Both SeaBIOS and qboot are x86-specific.

Link: 
https://lore.kernel.org/r/20250124-kunit-qboot-v1-1-815e4d4c6...@google.com
Signed-off-by: Brendan Jackman <jackm...@google.com>
Reviewed-by: David Gow <david...@google.com>
Signed-off-by: Shuah Khan <sk...@linuxfoundation.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 tools/testing/kunit/qemu_configs/x86_64.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/kunit/qemu_configs/x86_64.py 
b/tools/testing/kunit/qemu_configs/x86_64.py
index dc79490768630..4a6bf4e048f5b 100644
--- a/tools/testing/kunit/qemu_configs/x86_64.py
+++ b/tools/testing/kunit/qemu_configs/x86_64.py
@@ -7,4 +7,6 @@ CONFIG_SERIAL_8250_CONSOLE=y''',
                           qemu_arch='x86_64',
                           kernel_path='arch/x86/boot/bzImage',
                           kernel_command_line='console=ttyS0',
-                          extra_qemu_params=[])
+                          # qboot is faster than SeaBIOS and doesn't mess up
+                          # the terminal.
+                          extra_qemu_params=['-bios', 'qboot.rom'])
-- 
2.39.5


Reply via email to