On Mon, Apr 21, 2025 at 01:40:50PM +0200, barnabas.cze...@mainlining.org wrote: > On 2025-04-21 12:38, Dmitry Baryshkov wrote: > > On Mon, Apr 21, 2025 at 04:04:16AM +0200, Barnabás Czémán wrote: > > > mbox_request_channel() returning value was changed in case of error. > > > It uses returning value of of_parse_phandle_with_args(). > > > It is returning with -ENOENT instead of -ENODEV when no mboxes > > > property > > > exists. > > > > Why? What is the rationale? > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/of/base.c#n1390 > mailbox: use error ret code of of_parse_phandle_with_args() this commit was > changed the return value > from ENODEV to use retrun value of of_parse_phandle_with_args what is > returnung with EINVAL or ENOENT. > It makes skipping fallback path to parse qcom,ipc if there is no mboxes > property defined. > As far as I know qcom,ipc now only needed for rpm smd-edge on some SoCs like > 8939, 8916, 8976, 8917. > arm64: dts: qcom: msm8939: revert use of APCS mbox for RPM > >
Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com> -- With best wishes Dmitry
