On Sun, Apr 20, 2025 at 07:14:12PM +0200, Luca Weiss wrote:
> Hi Bjorn,
>
> On 20-04-2025 7:05 p.m., Bjorn Andersson wrote:
> > On Sat, Apr 19, 2025 at 11:03:57AM +0200, Luca Weiss wrote:
> > > Add an alias for the internal storage so it always becomes mmcblk0.
> > >
> >
> > https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> > calls for a problem description to start your commit message. Sometimes
> > the problem is obvious, but here &sdhc_2 is disable on this board, so
> > when does this not become mmcblk0? What is the problem you're solving?
>
> I have really seen internal storage become mmcblk1 on one of these devices
> with no SD card. I can't recall which one anymore, but this was the main
> idea why I wrote these patches. Maybe it's something to do with the mmc wifi
> on some of the boards?
>
> But I think it's not a bad idea to make this explicit for all, and align the
> boards with each other.
>
Thanks for clarifying. I have no concrete objections to the patch, but
from the commit message it's not clear if this patch solves a problem or
not. So, please incorporate your motivation in the commit message.
Thanks,
Bjorn
> Regards
> Luca
>
> >
> > Regards,
> > Bjorn
> >
> > > Signed-off-by: Luca Weiss <l...@lucaweiss.eu>
> > > ---
> > > arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> > > b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> > > index
> > > 4c8edadea0ac63db668dbd666fbb8d92e23232b7..88ff6535477bffefe475cc5fe927b3cc5d223084
> > > 100644
> > > --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> > > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> > > @@ -13,6 +13,7 @@ / {
> > > qcom,board-id = <8 0>;
> > > aliases {
> > > + mmc0 = &sdhc_1;
> > > serial0 = &blsp1_uart2;
> > > };
> > >
> > > --
> > > 2.49.0
> > >
>
