On Wed, Apr 9, 2025 at 4:28 PM Andrii Nakryiko <andrii.nakry...@gmail.com> wrote: > > On Tue, Apr 8, 2025 at 11:33 AM Malaya Kumar Rout > <malayarou...@gmail.com> wrote: > > > > Static Analyis for bench_htab_mem.c with cppcheck:error > > typo: analysis (lower case and typo) > > you can also make into a bit more human-readable sentence: > > "Static analysis found an issue in bench_htab_mem.c: > > > > tools/testing/selftests/bpf/benchs/bench_htab_mem.c:284:3: > > error: Resource leak: fd [resourceLeak] > > tools/testing/selftests/bpf/prog_tests/sk_assign.c:41:3: > > error: Resource leak: tc [resourceLeak] > > > > fix the issue by closing the file descriptor (fd & tc) when > > read & fgets operation fails. > > "Fix the issue by closing" (capitalization, single space between words > > > > > Signed-off-by: Malaya Kumar Rout <malayarou...@gmail.com> > > --- > > tools/testing/selftests/bpf/benchs/bench_htab_mem.c | 3 +-- > > tools/testing/selftests/bpf/prog_tests/sk_assign.c | 4 +++- > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > For some reason this patch didn't make it into our Patchworks system, > so we can't easily apply it. Please fix the above commit issues and > resubmit, hopefully this time it goes through just fine.
I thought it was a maintenance issue with patchwork, but it's probably something else. I'm guessing your cc list confuses pw bot. Pls drop linux-kselftest@vger and lkml@vger and keep bpf@vger only.
