The rcu_torture_reader() and rcu_torture_fwd_prog_cr() functions
run CPU-bound for extended periods of time (tens or even
hundreds of milliseconds), so they invoke tick_dep_set_task() and
tick_dep_clear_task() to ensure that the scheduling-clock tick helps
move grace periods forward.

So why doesn't rcu_torture_fwd_prog_nr() also invoke tick_dep_set_task()
and tick_dep_clear_task()?  Because the point of this function is to test
RCU's ability to (eventually) force grace periods forward even when the
tick has been disabled during long CPU-bound kernel execution.

Signed-off-by: Paul E. McKenney <paul...@kernel.org>
---
 kernel/rcu/rcutorture.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 7eccc74e60a7f..ea40f3ad32dc2 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -2410,7 +2410,7 @@ rcu_torture_reader(void *arg)
        set_user_nice(current, MAX_NICE);
        if (irqreader && cur_ops->irq_capable)
                timer_setup_on_stack(&t, rcu_torture_timer, 0);
-       tick_dep_set_task(current, TICK_DEP_BIT_RCU);
+       tick_dep_set_task(current, TICK_DEP_BIT_RCU);  // CPU bound, so need 
tick.
        do {
                if (irqreader && cur_ops->irq_capable) {
                        if (!timer_pending(&t))
@@ -3260,7 +3260,7 @@ static void rcu_torture_fwd_prog_cr(struct rcu_fwd *rfp)
        cver = READ_ONCE(rcu_torture_current_version);
        gps = cur_ops->get_gp_seq();
        rfp->rcu_launder_gp_seq_start = gps;
-       tick_dep_set_task(current, TICK_DEP_BIT_RCU);
+       tick_dep_set_task(current, TICK_DEP_BIT_RCU);  // CPU bound, so need 
tick.
        while (time_before(jiffies, stopat) &&
               !shutdown_time_arrived() &&
               !READ_ONCE(rcu_fwd_emergency_stop) && !torture_must_stop()) {
-- 
2.40.1


Reply via email to