Dear Uros,
Am 04.04.25 um 12:24 schrieb Uros Bizjak:
Current version of genksyms doesn't know anything about __typeof_unqual__()
operator. Avoid the usage of __typeof_unqual__() with genksyms to prevent
errors when symbols are versioned.
There were no problems with gendwarfksyms.
Signed-off-by: Uros Bizjak <ubiz...@gmail.com>
Fixes: ac053946f5c40 ("compiler.h: introduce TYPEOF_UNQUAL() macro")
Reported-by: Paul Menzel <pmen...@molgen.mpg.de>
Closes:
https://lore.kernel.org/lkml/81a25a60-de78-43fb-b56a-131151e1c...@molgen.mpg.de/
Cc: Sami Tolvanen <samitolva...@google.com>
Cc: Andrew Morton <a...@linux-foundation.org>
---
include/linux/compiler.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index 27725f1ab5ab..98057f93938c 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -229,10 +229,10 @@ void ftrace_likely_update(struct ftrace_likely_data *f,
int val,
/*
* Use __typeof_unqual__() when available.
*
- * XXX: Remove test for __CHECKER__ once
- * sparse learns about __typeof_unqual__().
+ * XXX: Remove test for __GENKSYMS__ once "genksyms" handles
+ * __typeof_unqual__(), and test for __CHECKER__ once "sparse" handles it.
*/
-#if CC_HAS_TYPEOF_UNQUAL && !defined(__CHECKER__)
+#if CC_HAS_TYPEOF_UNQUAL && !defined(__GENKSYMS__) && !defined(__CHECKER__)
# define USE_TYPEOF_UNQUAL 1
#endif
Thank you for your patch, that fixes my reported issue.
Tested-by: Paul Menzel <pmen...@molgen.mpg.de> # warning `cryptd: no
symbol version for this_cpu_off is gone`
Kind regards,
Paul
