* Huang, Ying <[EMAIL PROTECTED]> wrote:
> + /* Assume pages are mapped as WB */
> + if (mode == IOR_MODE_UNCACHED)
> + set_memory_uc(md->virt_addr, md->num_pages);
> + /* Assume pages are mapped as unexecutable */
> + if ((__supported_pte_mask & _PAGE_NX) &&
> + xmode == IOR_XMODE_EXEC)
> + set_memory_x(md->virt_addr, md->num_pages);
hm, why is the check for __supported_pte_mask needed? That is already
listened to in set_memory_x(). [if not then it's an ioremap bug that we
want to fix.]
> -static int ioremap_change_attr(unsigned long paddr, unsigned long size,
> - enum ioremap_mode mode,
> - enum ioremap_xmode xmode)
> +int ioremap_change_attr(unsigned long paddr, unsigned long size,
> + enum ioremap_mode mode,
> + enum ioremap_xmode xmode)
hm, there should be no need to use this raw API.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
