On 3/26/25 13:25, David Binderman wrote:
Hello there,
Static analyser cppcheck says:
linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:1061:11: style: int
result is assigned to long long variable. If the variable is long long to avoid
loss of information, then you have loss of information.
[truncLongCastAssignment]
linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:1510:11: style: int
result is assigned to long long variable. If the variable is long long to avoid
loss of information, then you have loss of information.
[truncLongCastAssignment]
linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:1523:11: style: int
result is assigned to long long variable. If the variable is long long to avoid
loss of information, then you have loss of information.
[truncLongCastAssignment]
linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:247:11: style: int result
is assigned to long long variable. If the variable is long long to avoid loss
of information, then you have loss of information. [truncLongCastAssignment]
linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:435:11: style: int result
is assigned to long long variable. If the variable is long long to avoid loss
of information, then you have loss of information. [truncLongCastAssignment]
linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:490:11: style: int result
is assigned to long long variable. If the variable is long long to avoid loss
of information, then you have loss of information. [truncLongCastAssignment]
The source code of the first one is
mem_size = 10 * page_size;
Maybe better code:
mem_size = 10ULL * page_size;
Regards
David Binderman
Can you send a patch for us to review?
thanks,
-- Shuah
