On Mon, 24 Feb 2025 at 19:34, Yosry Ahmed <yosry.ah...@linux.dev> wrote: > > +#ifdef CONFIG_KUNIT > > Why not CONFIG_PAGE_ALLOC_KUNIT_TEST?
VISIBLE_IF_KUNIT is paired with #ifdef CONFIG_KUNIT elsewhere (I think there might even be docs that do this in an example) so I just followed the pattern. #ifdef CONFIG_KUNIT -> things are consistent and you just don't have to think about this very much. #ifdef CONFIG_PAGE_ALLOC_KUNIT_TEST -> better scoping. So yeah, shrug. Maybe David/Rae/Brendan has an opinion.
