On 2/5/25 04:23, Mark Brown wrote:
> The thuge-gen test_mmap() and test_shmget() tests are repeatedly run for a
> variety of sizes but always report the result of their test with the same
> name, meaning that automated sysetms running the tests are unable to
s/sysetms/system ^^^^^^
> distinguish between the various tests. Add the supplied sizes to the logged
> test names to distinguish between runs.
This makes sense given that the size parameter is available right away.
>
> Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output")
Just wondering how this fixes anything ? This seems like an improvement to
the current behaviour.
> Signed-off-by: Mark Brown <broo...@kernel.org>
> ---
> tools/testing/selftests/mm/thuge-gen.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/thuge-gen.c
> b/tools/testing/selftests/mm/thuge-gen.c
> index
> e4370b79b62ffb133056eb843cdd1eaeba6503df..cd5174d735be405220d99ae796a3768f53df6ea4
> 100644
> --- a/tools/testing/selftests/mm/thuge-gen.c
> +++ b/tools/testing/selftests/mm/thuge-gen.c
> @@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags)
>
> show(size);
> ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
> - "%s mmap\n", __func__);
> + "%s mmap %lu\n", __func__, size);
>
> if (munmap(map, size * NUM_PAGES))
> ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno));
> @@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags)
>
> show(size);
> ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
> - "%s: mmap\n", __func__);
> + "%s: mmap %lu\n", __func__, size);
> if (shmdt(map))
> ksft_exit_fail_msg("%s: shmdt: %s\n", __func__,
> strerror(errno));
> }
>
Otherwise LGTM.
