On Jan 30, 2008 10:02 AM, Bryan Wu <[EMAIL PROTECTED]> wrote: switch_to_flash is calling SSYNC():
> +static void switch_to_flash(struct flash_save *save) > +{ > + local_irq_save(save->flags); > + > + gpio_set_value(enet_flash_pin, 0); > + SSYNC(); > + > + save->ambctl0 = bfin_read_EBIU_AMBCTL0(); > + save->ambctl1 = bfin_read_EBIU_AMBCTL1(); > + bfin_write_EBIU_AMBCTL0(BFIN_FLASH_AMBCTL0VAL); > + bfin_write_EBIU_AMBCTL1(BFIN_FLASH_AMBCTL1VAL); > + SSYNC(); > +} > + > +static void switch_back(struct flash_save *save) > +{ > + bfin_write_EBIU_AMBCTL0(save->ambctl0); > + bfin_write_EBIU_AMBCTL1(save->ambctl1); > + SSYNC(); > + > + gpio_set_value(enet_flash_pin, 1); > + > + local_irq_restore(save->flags); > +} > + > +static map_word bf5xx_read(struct map_info *map, unsigned long ofs) > +{ > + int nValue = 0x0; > + map_word test; > + struct flash_save save; > + > + switch_to_flash(&save); > + SSYNC(); Is it necessary to SSYNC() here as well? > + nValue = readw(map->virt + ofs); > + SSYNC(); > + switch_back(&save); > + > + test.x[0] = (u16)nValue; > + return test; > +} > + > +static void bf5xx_copy_from(struct map_info *map, void *to, unsigned long > from, ssize_t len) > +{ > + unsigned long i; > + map_word test; > + > + if ((unsigned long)to & 0x1) { > + for (i = 0; i < len / 2 * 2; i += 2) { > + test = bf5xx_read(map, from + i); > + put_unaligned(test.x[0], (__le16 *)(to + i)); > + } > + } else { > + for (i = 0; i < len / 2 * 2; i += 2) { > + test = bf5xx_read(map, from + i); > + *((u16*)(to + i)) = test.x[0]; > + } > + } > + > + if (len & 0x1) { > + test = bf5xx_read(map, from + i); > + *((u8*)(to + i)) = (u8)test.x[0]; > + } > +} > + > +static void bf5xx_write(struct map_info *map, map_word d1, unsigned long ofs) > +{ > + u16 d; > + struct flash_save save; > + > + d = (u16)d1.x[0]; > + > + switch_to_flash(&save); > + > + SSYNC(); Also here? > + writew(d, map->virt + ofs); > + SSYNC(); > + > + switch_back(&save); > +} -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/